Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Filters (glob, regexp etc.) seemingly cannot contain a space after the colon #3041

Closed
anlutro opened this issue May 1, 2020 · 1 comment
Closed
Labels
blocked-needs-validation Issue is waiting to be validated before we can proceed bug

Comments

@anlutro
Copy link

anlutro commented May 1, 2020

This is either a bug in code or in documentation.

Judging by this documentation, glob: foo-* should be a valid filter.

However, I just spent an hour debugging Flux when the solution turned out to be changing glob: foo-* to glob:foo-*.

I quickly glanced over the code and didn't see any trimming of whitespace going on in pattern.go so I suppose this is just something that snuck into documentation.

It would be nice to support using spaces like this, though.

@anlutro anlutro added blocked-needs-validation Issue is waiting to be validated before we can proceed bug labels May 1, 2020
@circa10a
Copy link
Contributor

@anlutro docs were updated

@anlutro anlutro closed this as completed May 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked-needs-validation Issue is waiting to be validated before we can proceed bug
Projects
None yet
Development

No branches or pull requests

2 participants