Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resurrect the --docker-config flag for local use #1065

Merged
merged 1 commit into from May 17, 2018

Conversation

@squaremo
Copy link
Member

squaremo commented May 4, 2018

We deprecated the --docker-config flag when we switched to looking up
imagePullSecrets to get credentials. However, it's still useful if
you're not using those -- for example, if you don't pull images from
the registry, or (less so) if you assign credentials to service
accounts.

This commit brings the flag back, and implements it by loading the
given docker config file, to supplement any credentials found via
imagePullSecrets.

We deprecated the --docker-config flag when we switched to looking up
imagePullSecrets to get credentials. However, it's still useful if
you're not using those -- for example, if you don't pull images from
the registry, or (less so) if you assign credentials to service
accounts.

This commit brings the flag back, and implements it by loading the
given docker config file, to supplement any credentials found via
imagePullSecrets.
@squaremo squaremo requested a review from aaron7 May 15, 2018
@aaron7
aaron7 approved these changes May 17, 2018
@squaremo squaremo merged commit 6f8a477 into master May 17, 2018
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@squaremo squaremo deleted the feature/more-local branch May 17, 2018
@squaremo squaremo mentioned this pull request May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.