Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a friendly message when flux can't parse YAMLs #1141

Merged
merged 3 commits into from Jun 19, 2018

Conversation

@squaremo
Copy link
Member

squaremo commented Jun 13, 2018

Fixes #1123.

(also gets rid of some effectively dead code)

squaremo added 3 commits Jun 13, 2018
FindDefinedServices was a holdover from when we had a very particular
interpretation of what a service was.

We can rewrite UpdateManifests to avoid using FindDefinedServices,
since we have more general-purpose procedures for loading things from
files now.
@squaremo squaremo requested a review from rndstr Jun 13, 2018
@rndstr
rndstr approved these changes Jun 19, 2018
Copy link
Contributor

rndstr left a comment

Works nicely and code LGTM 👌

@squaremo squaremo merged commit fd3bdde into master Jun 19, 2018
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@squaremo squaremo deleted the issue/1123-better-badyaml branch Jun 19, 2018
@squaremo

This comment has been minimized.

Copy link
Member Author

squaremo commented Jun 19, 2018

Thanks Roli! 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.