Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm-op: Add git hosts to known hosts in /etc/ssh/ssh_known_hosts #1188

Merged
merged 1 commit into from Jul 2, 2018

Conversation

@stefanprodan
Copy link
Member

commented Jul 2, 2018

Port the know hosts changes from Flux to Flux Helm Operator ref #1154

@stefanprodan stefanprodan requested a review from squaremo Jul 2, 2018

@squaremo squaremo changed the title Add git hosts to known hosts in /etc/ssh/ssh_known_hosts helm-op: Add git hosts to known hosts in /etc/ssh/ssh_known_hosts Jul 2, 2018

@squaremo
Copy link
Member

left a comment

Looks like a faithful port of the changes, and seems like that's what is needed. Thanks Stefan ⭐️

@stefanprodan stefanprodan merged commit 2356441 into master Jul 2, 2018

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details

@stefanprodan stefanprodan deleted the fixhelm branch Jul 2, 2018

@stephenmoloney

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2018

This change will surely impact the helm chart which uses /root/.ssh/known_hosts as the dir ... I'll make a PR for that.

stephenmoloney added a commit to stephenmoloney/flux that referenced this pull request Jul 2, 2018
change sshdir mounth path to /etc/ssh/ssh_known_hosts
What does this PR do?

- Changes the mount path for known_hosts

Why is this PR needed?

- To bring the helm templates inline with the changes to the Dockerfile
in PR fluxcd#1188.
@squaremo

This comment has been minimized.

Copy link
Member

commented Jul 2, 2018

This change will surely impact the helm chart which uses /root/.ssh/known_hosts as the dir ... I'll make a PR for that.

The git code will look in both places; so it is intended that the image has the config and known_hosts in /etc/ssh/, and the chart mounts them into /root/.ssh/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.