Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent bogus manifest fetching success #1251

Merged
merged 1 commit into from Jul 25, 2018

Conversation

@rade
Copy link
Contributor

commented Jul 24, 2018

An error while fetching an image manifest would return a nil error (hence indicating success) with a unit value image.Info{} struct.

That is bad news for the caller in Warmer.warm(), which will map an image tag to that empty image.Info{}, polluting the cache entry for the image+tag and image in memcached.

When we subsequently use this info to determine the latest suitable tag, we encounter zero CreatedAt timestamps, which, prior to the changes in #1247, #1249 and #1250 would cause the wrong images to be released.

Fixes #1127.

An error while fetching an image manifest would return a nil
error (hence indicating success) with a unit value image.Info{}
struct.

That is bad news for the caller in Warmer.warm(), which will map an
image tag to that empty image.Info{}, polluting the cache entry for
the image+tag and image in memcached.

When we subsequently use this info to determine the latest suitable
tag, we encounter zero CreatedAt timestamps, which, prior to the
changes in #1247, #1249 and #1250 would cause the wrong images to be
released.

Fixes #1127.
@rade rade requested a review from squaremo Jul 24, 2018
Copy link
Member

left a comment

Another ops! Well found.

@squaremo squaremo merged commit dd09ee8 into master Jul 25, 2018
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@squaremo squaremo deleted the 1127-manifest-fetch branch Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.