Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple `-git-path` arguments #1297

Merged
merged 1 commit into from Aug 22, 2018

Conversation

@squaremo
Copy link
Member

squaremo commented Aug 20, 2018

The idea is to let people overlay bits of configuration by supplying more than one --git-path argument.

Much of the machinery for dealing with manifest files (and directories) already expected more than one path; but, it wasn't necessarily convenient to supply all of them in one go, so I've updated the Manifests interface and followed that through.

The git path appears in API results -- it's just an opaque string, though, so joining the now multiple paths and returning that should be fine.

Fixes #1267.

@squaremo

This comment has been minimized.

Copy link
Member Author

squaremo commented Aug 21, 2018

it's just an opaque string, though, so joining the now multiple paths and returning that should be fine.

This is not quite true; if you round-trip this, and supply comma-delimited paths as the value for --git-path, it won't work. You need to break it into multiple --git-path arguments.

EDIT: Nope, right the first time. I fooled myself by applying a weave cloud config, which of course uses the released daemon and thus doesn't understand this argument.

@squaremo squaremo requested a review from rndstr Aug 21, 2018
@rndstr
rndstr approved these changes Aug 21, 2018
Copy link
Contributor

rndstr left a comment

Code LGTM!

return ids
}

// getUnlockedAutomatedServices returns all the resources that are

This comment has been minimized.

Copy link
@rndstr

rndstr Aug 21, 2018

Contributor

the suspension is real!

This comment has been minimized.

Copy link
@squaremo

squaremo Aug 22, 2018

Author Member

😂 owps, will try harder to complete my sentences.

The idea is to let people overlay bits of configuration by supplying
more than one `--git-path` argument.

Much of the machinery for dealing with manifest files (and
directories) already expected more than one path; but, it wasn't
necessarily convenient to supply all of them in one go, so I've
updated the Manifests interface and followed that through.

The git path appears in API results -- it's just an opaque string,
though, so joining the now multiple paths and returning that should be
fine.
@squaremo squaremo force-pushed the issue/1267-multiple-paths branch from 5f2de14 to 8f09ae6 Aug 22, 2018
@squaremo

This comment has been minimized.

Copy link
Member Author

squaremo commented Aug 22, 2018

Rebassed and cliffhanger comment resolved.

@squaremo squaremo merged commit 670fce0 into master Aug 22, 2018
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@squaremo squaremo deleted the issue/1267-multiple-paths branch Aug 22, 2018
@stephenmoloney

This comment has been minimized.

Copy link
Contributor

stephenmoloney commented Sep 21, 2018

Just wondering:

  1. if the docs show how this works ?

  2. If there is an open issue to support something similar for the helmOperator ? (found the relevant issue here

@squaremo

This comment has been minimized.

Copy link
Member Author

squaremo commented Sep 21, 2018

  1. if the docs show how this works ?

Possibly only the usage message :-S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.