Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memcache logging by default #1369

Merged
merged 1 commit into from Sep 18, 2018

Conversation

@alanjcastonguay
Copy link
Contributor

alanjcastonguay commented Sep 17, 2018

Unless debugging the image data being cached in memcached,
there is no value in recording all requests and responses between
fluxd and memcached into the logs. Reduce the logging, but
leave behind the comment in case someone needs it.

Unless debugging the image data being cached in memcached,
there is no value in recording all requests and responses between
fluxd and memcached into the logs. Reduce the logging, but
leave behind the comment in case someone needs it.
@alanjcastonguay

This comment has been minimized.

Copy link
Contributor Author

alanjcastonguay commented Sep 17, 2018

I deployed this manifest without thinking, and paid about $248 last month
to store (replicated) memcached logs. That's a lot of beer. I have since
modified my deployment, but I hope to save someone else from having the
same initial experience with Flux.

Copy link
Member

squaremo left a comment

An overdue change, thank you for this. Sorry about the beer :-S

@squaremo squaremo merged commit 5e2410f into fluxcd:master Sep 18, 2018
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
squaremo added a commit that referenced this pull request Sep 26, 2018
Reduce memcache logging by default
squaremo added a commit that referenced this pull request Oct 4, 2018
This pulls the release branch 1.7.x back into master, so that master
gets the changelog entry for the 1.7.1 release.

Below are the cherry-picked changes that were on the release/1.7.x
branch at the time of this merge.

* origin/release/1.7.x:
  Update changelog for v1.7.1
  Merge pull request #1389 from dholbach/fix-827
  Merge pull request #1372 from weaveworks/issue/1371-podcontroller-encapsulation
  Merge pull request #1369 from alanjcastonguay/patch-1
@alanjcastonguay alanjcastonguay deleted the alanjcastonguay:patch-1 branch Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.