Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include initContainers in images to fetch #1372

Merged
merged 1 commit into from Sep 19, 2018

Conversation

@squaremo
Copy link
Member

squaremo commented Sep 18, 2018

Symptom: images used in initContainers, but not elsewhere, don't get
metadata fetched for them, and don't get automated updates.

Fix: the ImagesToFetch method of the cluster, supplied to the image DB
as the way to get a list of all the images to fetch, didn't look in
initContainers. So, make it do that.

Fixes #1371.

Symptom: images used in initContainers, but not elsewhere, don't get
metadata fetched for them, and don't get automated updates.

Fix: the ImagesToFetch method of the cluster, supplied to the image DB
as the way to get a list of all the images to fetch, didn't look in
initContainers. So, make it do that.
Copy link
Member

stefanprodan left a comment

It works 🎉 Tested with the deployment yaml from #1371

screen shot 2018-09-18 at 19 26 02

@squaremo squaremo merged commit 0571ecc into master Sep 19, 2018
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@squaremo squaremo deleted the issue/1371-podcontroller-encapsulation branch Sep 19, 2018
@squaremo

This comment has been minimized.

Copy link
Member Author

squaremo commented Sep 19, 2018

Brill, thanks very much for the quick turnaround on review Stefan 🍬

squaremo added a commit that referenced this pull request Sep 26, 2018
…apsulation

Include initContainers in images to fetch
squaremo added a commit that referenced this pull request Oct 4, 2018
This pulls the release branch 1.7.x back into master, so that master
gets the changelog entry for the 1.7.1 release.

Below are the cherry-picked changes that were on the release/1.7.x
branch at the time of this merge.

* origin/release/1.7.x:
  Update changelog for v1.7.1
  Merge pull request #1389 from dholbach/fix-827
  Merge pull request #1372 from weaveworks/issue/1371-podcontroller-encapsulation
  Merge pull request #1369 from alanjcastonguay/patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.