Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to kubeyaml 0.5.1 to fix (F)HR updating #1507

Merged
merged 1 commit into from Nov 14, 2018
Merged

Conversation

@squaremo
Copy link
Member

squaremo commented Nov 13, 2018

kubeyaml 0.5.1 has a fix for updating images that include ports in
(Flux)HelmRelease manifests. So: bump that in the Dockerfile and shim
(/bin/kubeyaml), and add a test that it does account for such images
when updating.

Side issue in update_test.go: calling t.Parallel() before invoking
the test case meant that the closed-over loop variable could be
reassigned before the test case was run.

Fixes #1504.

kubeyaml 0.5.1 has a fix for updating images that include ports in
(Flux)HelmRelease manifests. So: bump that in the Dockerfile and shim
(`/bin/kubeyaml`), and add a test that it does account for such images
when updating.

Side issue in update_test.go: calling `t.Parallel()` _before_ invoking
the test case meant that the closed-over loop variable could be
reassigned before the test case was run.
@squaremo squaremo requested a review from rndstr Nov 13, 2018
@squaremo

This comment has been minimized.

Copy link
Member Author

squaremo commented Nov 13, 2018

Roli, do you mind having a look at this? Checking that the additional test actually tests something that could (and previously, did) fail would be adequate I reckon.

@rndstr
rndstr approved these changes Nov 14, 2018
Copy link
Contributor

rndstr left a comment

tests fail with 0.5.0 by not showing the proper values (tag) but pass with 0.5.1 👌

@squaremo squaremo merged commit 0d6fe19 into master Nov 14, 2018
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@squaremo squaremo deleted the bump/kubeyaml-0.5.1 branch Nov 14, 2018
@squaremo

This comment has been minimized.

Copy link
Member Author

squaremo commented Nov 14, 2018

Thanks @rndstr 🍧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.