Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue when k8s returns Forbidden when getting resources of resourc… #1620

Merged
merged 1 commit into from Dec 31, 2018

Conversation

@gellweiler
Copy link

gellweiler commented Dec 28, 2018

When flux is used with more restricted permissions (as is required in our kubernetes cluster) k8s will create a 403 instead of an 404 error when trying to get missing resources (such as helm resources).

This is why I would propose generating a warning but continuing with the sync process in such instances.

@gellweiler gellweiler force-pushed the gellweiler:master branch from 8465a4b to ae977c6 Dec 28, 2018
Copy link
Member

squaremo left a comment

This is a sensible change; thank you 🍍

@squaremo squaremo merged commit 9ce57ef into fluxcd:master Dec 31, 2018
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.