Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky cached discovery test #1849

Merged
merged 1 commit into from Mar 21, 2019

Conversation

@2opremio
Copy link
Collaborator

2opremio commented Mar 20, 2019

The synchronization handle needs to be called last, to make sure the invalidation
handle is called before invoking lookupNamespaced()

@2opremio 2opremio requested a review from squaremo Mar 20, 2019
@2opremio 2opremio changed the title Fix flakey cache discovery test Fix flaky cache discovery test Mar 21, 2019
@2opremio 2opremio force-pushed the 2opremio:fix-flakey-discovery-test branch from b32badd to 60cb318 Mar 21, 2019
@2opremio 2opremio changed the title Fix flaky cache discovery test Fix flaky cached discovery test Mar 21, 2019
The synchronization handle needs to be called last, to make sure the invalidation
handle is called before invoking `lookupNamespaced()`
@2opremio 2opremio force-pushed the 2opremio:fix-flakey-discovery-test branch from 60cb318 to 20e8abd Mar 21, 2019
Copy link
Member

squaremo left a comment

Makes sense! Then we're not at the mercy of the go scheduler.

@2opremio 2opremio merged commit 88402e3 into fluxcd:master Mar 21, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@2opremio 2opremio deleted the 2opremio:fix-flakey-discovery-test branch Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.