Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `regex` an alias of `regexp` tag filter type #1915

Merged
merged 1 commit into from Apr 10, 2019

Conversation

@hiddeco
Copy link
Member

commented Apr 10, 2019

The word regex seems to be a common alias of regexp, so people often use this and are left with confusion when Flux does not adhere to what they configured.

Make it an alias to better live up to people their expectations.

@hiddeco hiddeco force-pushed the regexp-regex-alias branch 2 times, most recently from f5b5b74 to 2a1264c Apr 10, 2019
policy/pattern.go Outdated Show resolved Hide resolved
The word `regex` seems to be a common alias of `regexp`, so people
often use this and are left with confusion when Flux does not adhere
to what they configured.

Make it an alias to better live up to people their expectations.
@hiddeco hiddeco force-pushed the regexp-regex-alias branch from 2a1264c to dfc63b6 Apr 10, 2019
@hiddeco hiddeco requested a review from squaremo Apr 10, 2019
Copy link
Member

left a comment

Yup all good 🍐

@hiddeco hiddeco merged commit 0362217 into master Apr 10, 2019
3 of 4 checks passed
3 of 4 checks passed
tag-filter tag-filter
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: e2e-testing Your tests passed on CircleCI!
Details
helm-lint helm-lint
Details
@hiddeco hiddeco deleted the regexp-regex-alias branch Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.