Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup arm and arm64 builds; Refactor Makefile; #1950

Merged
merged 1 commit into from Apr 20, 2019
Merged

Conversation

@brezerk
Copy link
Contributor

brezerk commented Apr 17, 2019

HW: Rock64 (arm64v8)
OS: Gentoo

Hi

Thank you for nice DevOps tool. I was looking forward to build if for my arm64 k8s cluster and got some issues.

Here you are the changes I had to make to compile the binaries and build the images.

Also, i have noticed comments/discussions around #1761 , #1411 and #1474 so i have tried to update Makefile accordingly.

Retry for #1942 :)

@brezerk

This comment has been minimized.

Copy link
Contributor Author

brezerk commented Apr 17, 2019

Okay. I finally got tests passed :) jfyi: @2opremio

bin/upload-binaries Outdated Show resolved Hide resolved
bin/upload-binaries Outdated Show resolved Hide resolved
@2opremio

This comment has been minimized.

Copy link
Collaborator

2opremio commented Apr 18, 2019

Great work! it's shaping up nicely!

Wanna bite the bullet and create multi-architecture images when pushing from CircleCI? It can be done in a separate PR if you want.

The advantage of that is that people interested in ARM images won't have to build locally.

@brezerk brezerk force-pushed the brezerk:master branch from c339993 to b333cae Apr 18, 2019
@brezerk

This comment has been minimized.

Copy link
Contributor Author

brezerk commented Apr 18, 2019

Yup, I'd love to see official multi-architecture images too.
However i'll need couple days to get acquainted with circleci tool and binfmt_misc approach used in prometheus/prometheus#5031

I'd vote for a separate PR :)

site/building.md Outdated Show resolved Hide resolved
@2opremio

This comment has been minimized.

Copy link
Collaborator

2opremio commented Apr 18, 2019

Yup, I'd love to see official multi-architecture images too.

Awesome!! Looking forward to that work.

Almost ready to merge, just a small nitpick.

@brezerk brezerk force-pushed the brezerk:master branch from b333cae to 22fb8b6 Apr 19, 2019
@2opremio 2opremio merged commit 855b9b1 into fluxcd:master Apr 20, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: e2e-testing Your tests passed on CircleCI!
Details
dholbach added a commit to dholbach/flux that referenced this pull request Apr 23, 2019
Fixup arm and arm64 builds; Refactor Makefile;
@squaremo

This comment has been minimized.

Copy link
Member

squaremo commented Apr 24, 2019

This is thorough and neatly done -- thanks for giving it another go @brezerk

@squaremo squaremo added this to the v1.12.1 milestone Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.