Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error shadowing when parsing manifests #1994

Merged
merged 2 commits into from Apr 29, 2019

Conversation

@2opremio
Copy link
Collaborator

commented Apr 29, 2019

This caused parsing errors in YAML files to go unnoticed (the files where simply
not included in the result)

This caused parsing errors in YAML files to go unnoticed (the files where simply
not included in the result)
@2opremio 2opremio requested a review from hiddeco Apr 29, 2019
@2opremio

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 29, 2019

Introduced in #1931

@hiddeco hiddeco added this to the v1.12.2 milestone Apr 29, 2019
@2opremio

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 29, 2019

Uhm, I should probably add a test. Will do it tomorrow

@2opremio 2opremio merged commit f592d43 into fluxcd:master Apr 29, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: e2e-testing Your tests passed on CircleCI!
Details
@2opremio 2opremio deleted the 2opremio:fix-error-shadowing branch Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.