Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TestCachedDiscovery more robust #2110

Merged
merged 1 commit into from May 29, 2019

Conversation

@2opremio
Copy link
Collaborator

2opremio commented May 29, 2019

We were relying on an Add event happening, but sometimes there is an Add followed by an Update.

As a bonus, we don't need to split the constructor in two

@2opremio 2opremio requested a review from hiddeco May 29, 2019
We were relying on an Add event happening, but sometimes there is an Add
followed by an update.

As a bonus, we don't need to split the constructor in two
@2opremio 2opremio force-pushed the flaky-disco-test branch from 8ea2ce4 to df07d9c May 29, 2019
Copy link
Member

hiddeco left a comment

Neat (and what a great day for our e2e tests) 🍰

@2opremio 2opremio merged commit 768f84d into master May 29, 2019
3 checks passed
3 checks passed
tag-filter tag-filter
Details
ci/circleci: build Your tests passed on CircleCI!
Details
helm-lint helm-lint
Details
@2opremio 2opremio deleted the flaky-disco-test branch May 29, 2019
@hiddeco hiddeco added this to the v1.13.0 milestone May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.