Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not trim space on list split #2117

Merged
merged 1 commit into from Jun 3, 2019
Merged

Do not trim space on list split #2117

merged 1 commit into from Jun 3, 2019

Conversation

@hiddeco
Copy link
Member

hiddeco commented May 31, 2019

As this leads to lstat errors when it is used to parse the git diff
output with filenames that have leading or trailing spaces.

Fixes #1481

@hiddeco hiddeco added this to the v1.13.0 milestone May 31, 2019
@hiddeco hiddeco requested a review from squaremo Jun 3, 2019
Copy link
Member

squaremo left a comment

This seems right to me. I think the original code may have been trying to account, inexactly, for git's output; but we can be more precise.

As this leads to `lstat` errors when it is used to parse the git diff
output with filenames that have leading or trailing spaces.
@hiddeco hiddeco force-pushed the bug/1481-filename-spaces branch from 5b4db79 to 1630772 Jun 3, 2019
@hiddeco hiddeco merged commit 86eed4d into master Jun 3, 2019
3 checks passed
3 checks passed
tag-filter tag-filter
Details
ci/circleci: build Your tests passed on CircleCI!
Details
helm-lint helm-lint
Details
@hiddeco hiddeco deleted the bug/1481-filename-spaces branch Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.