Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move lastKnownSyncTag out of for loop #2177

Merged
merged 1 commit into from Jun 24, 2019

Conversation

@hiddeco
Copy link
Member

commented Jun 21, 2019

Fixes #2167

As it now loses state on every for tick.
@hiddeco hiddeco requested review from squaremo and stefanprodan Jun 24, 2019
Copy link
Member

left a comment

Yup!

@hiddeco hiddeco merged commit a526626 into master Jun 24, 2019
2 of 3 checks passed
2 of 3 checks passed
tag-filter tag-filter
Details
ci/circleci: build Your tests passed on CircleCI!
Details
helm-lint helm-lint
Details
@hiddeco hiddeco deleted the fix/2167-sync-tag-state branch Jun 24, 2019
@davidkarlsen

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

*/ - awesome - when will it be released?

@hiddeco

This comment has been minimized.

Copy link
Member Author

commented Jun 24, 2019

@davidkarlsen Wednesday, there is however a prerelease available weaveworks/flux-prerelease:master-a5266263

@hiddeco hiddeco added this to the 1.13.1 milestone Jun 24, 2019
squaremo added a commit that referenced this pull request Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.