Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support both new fluxcd and original annotations #2219

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@squaremo
Copy link
Member

squaremo commented Jul 3, 2019

The new prefix for annotations is fluxcd.io; but, many files will
use flux.weave.works, and we don't want to suddenly not understand
the policies in those.

This commit adds support for interpreting and updating policies as
annotations with either prefix. When updating, if an annotation uses
the old prefix, that will be retained; otherwise, the new prefix is
used.

This change is backward-compatible, but we may want to keep it back until we're releasing other "decoupling" changes.

Fixes #2217.

@hiddeco
hiddeco approved these changes Jul 5, 2019
@squaremo squaremo added this to the decouple-from-weavecloud milestone Jul 8, 2019
@hiddeco hiddeco force-pushed the decouple/annotation-domain branch from 4d5d195 to 1f0162f Aug 1, 2019
The new prefix for annotations is `fluxcd.io`; but, many files will
use `flux.weave.works`, and we don't want to suddenly not understand
the policies in those.

This commit adds support for interpreting and updating policies as
annotations with either prefix. When updating, if an annotation uses
the old prefix, that will be retained; otherwise, the new prefix is
used.
@hiddeco hiddeco force-pushed the decouple/annotation-domain branch from 1f0162f to cc7c63f Aug 1, 2019
@hiddeco

This comment has been minimized.

Copy link
Member

hiddeco commented Aug 1, 2019

Getting this in to finish #2249 with the new annotation domain (and to support updates of existing annotations).

@hiddeco hiddeco merged commit c2427f5 into master Aug 1, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@hiddeco hiddeco deleted the decouple/annotation-domain branch Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.