Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken doc link #2306

Merged
merged 16 commits into from Jul 30, 2019
Merged

Fix broken doc link #2306

merged 16 commits into from Jul 30, 2019

Conversation

@rytswd
Copy link
Contributor

rytswd commented Jul 29, 2019

After #2152 has been merged, it looks like some of the doc had broken links to other docs due to the path changes. I just scanned all the *.md files that had some directory structure changes in that PR, and updated the entire repo with string replace.
I think I covered most use cases, but please shout if I missed / wrongly replaced any.

@rytswd

This comment has been minimized.

Copy link
Contributor Author

rytswd commented Jul 29, 2019

One correction, I did scan other files as well, and thus ended up touching .txt, .tmpl and .go one file each. They are purely for text usage, and I believe they are the correct fix.

As to the build failure, I'm uncertain how this PR can cause any build behaviour change from the previous run. I'm new to the flux repo, and would love if anyone can lend a hand looking into it.

@dholbach dholbach mentioned this pull request Jul 30, 2019
@@ -556,7 +556,7 @@ Commit customization
--git-user
--git-email
See [docs/daemon.md] for more information.
See [docs/features/daemon.md] for more information.

This comment has been minimized.

Copy link
@dholbach

dholbach Jul 30, 2019

Contributor

Maybe let's make this a real clickable link?

Copy link
Contributor

dholbach left a comment

Great work! 🍍

Copy link
Member

hiddeco left a comment

Thanks a lot for your first contribution @rytswd 🌻

@hiddeco hiddeco merged commit 3f0188f into fluxcd:master Jul 30, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@rytswd rytswd deleted the rytswd:fix-broken-doc-link branch Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.