Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: fix some typos in code comment #2381

Merged
merged 1 commit into from Aug 22, 2019

Conversation

@beautytiger
Copy link
Contributor

beautytiger commented Aug 21, 2019

Signed-off-by: Guangming Wang guangming.wang@daocloud.io

@@ -54,7 +54,7 @@ func NewContainer(name string, images imageSorter, currentImage image.Info, tagP
var c Container

// The following machinery attempts to minimise the number of
// filters (`O(n)`) and sorts (`O(n log n)`), by memoising and
// filters (`O(n)`) and sorts (`O(n log n)`), by memorizing and

This comment has been minimized.

Copy link
@squaremo

squaremo Aug 21, 2019

Member

This looks like a typo, but is not! https://en.wikipedia.org/wiki/Memoization (or in en_gb, "memoisation")

This comment has been minimized.

Copy link
@beautytiger

beautytiger Aug 22, 2019

Author Contributor

Got it, good lessons. Thanks!

revert non-typo in api/v6/container.go

Signed-off-by: Guangming Wang <guangming.wang@daocloud.io>
@beautytiger beautytiger force-pushed the beautytiger:typo-terminator branch from 9d5ad9d to b97dab4 Aug 22, 2019
Copy link
Member

squaremo left a comment

Helpful cleanup, thank you!

@squaremo squaremo merged commit d33e974 into fluxcd:master Aug 22, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: helm Your tests passed on CircleCI!
Details
@hiddeco hiddeco added this to the 1.14.1 milestone Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.