Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the files included in kube-config in snapcraft.yaml #2427

Merged
merged 3 commits into from Sep 10, 2019

Conversation

@dholbach
Copy link
Contributor

dholbach commented Sep 4, 2019

	As we can read more files this way, it will make
	fluxctl work in cases where
	   kind clusters have --name set.
@dholbach

This comment has been minimized.

Copy link
Contributor Author

dholbach commented Sep 5, 2019

I pinged Leigh, as this was relevant to some of his work, but can be reviewed by anyone really.

@stealthybox

This comment has been minimized.

Copy link
Contributor

stealthybox commented Sep 9, 2019

Does this allow recursive access to any kubeconfig file in the ~/.kube directory?
If so, +++++++100

dholbach and others added 2 commits Sep 10, 2019
Co-Authored-By: leigh capili <stealthybox@users.noreply.github.com>
@dholbach

This comment has been minimized.

Copy link
Contributor Author

dholbach commented Sep 10, 2019

Thanks for the edit @stealthybox - this is ready to go now. ✔️

Copy link
Member

hiddeco left a comment

Maintainer stamp of approval 📮

@dholbach dholbach merged commit 060023b into master Sep 10, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: helm Your tests passed on CircleCI!
Details
@dholbach dholbach deleted the snap-simplify-kubeconfig-files branch Sep 10, 2019
@dholbach

This comment has been minimized.

Copy link
Contributor Author

dholbach commented Sep 13, 2019

This had to go through the store review process, but is live in edge now:

Track    Arch    Channel    Version          Revision
latest   amd64   stable     1.14.2           30
                 candidate  ^                ^
                 beta       ^                ^
                 edge       1.14.2+bb576fad  35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.