Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the files included in kube-config in snapcraft.yaml #2427

Merged
merged 3 commits into from Sep 10, 2019
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -58,10 +58,9 @@ plugs:
kube-config:
interface: personal-files
read:
- $HOME/.kube/config
- $HOME/.minikube/client.key
- $HOME/.minikube/client.crt
- $HOME/.minikube/ca.crt
- $HOME/.kube
- $HOME/.minikube
This conversation was marked as resolved by dholbach

This comment has been minimized.

Copy link
@stealthybox

stealthybox Sep 9, 2019

Contributor

To support k3d we would need access to the host's $XDG_CONFIG_HOME, but that does not appear to be supported well by snap: thread

We can handle the common case by just hard-coding ~/.config:

Suggested change
- $HOME/.minikube
- $HOME/.minikube
- $HOME/.config/k3d # hard-coded $XDG_CONFIG_HOME for the common case

This comment has been minimized.

Copy link
@dholbach

dholbach Sep 10, 2019

Author Contributor

Thanks a lot for digging into this!

- $HOME/.config/k3d # hard-coded $XDG_CONFIG_HOME for the common case

apps:
fluxctl:
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.