Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `flux` namespace in `deploy/` examples #2475

Merged
merged 1 commit into from Sep 25, 2019
Merged

Conversation

@hiddeco
Copy link
Member

hiddeco commented Sep 25, 2019

This is so that the configuration is not effected by e.g. a namespace
context set in the kubectl config of the user, as this caused
problems during the creation of the ClusterRoleBinding which was set
to the default namespace, while the resources themselves would be
created in the user their configured namespace.

It also simplifies the 'Get started with Kustomize' guide, as a user
does no longer need to create the namespace as a prerequisite but is
still able to overwrite it by adding a namespace: <targetNamespace>
to their kustomization.yaml.

Supersedes #2454

@hiddeco hiddeco force-pushed the misc/ns-deploy-example branch 2 times, most recently from 94a2a95 to eefe4af Sep 25, 2019
@hiddeco hiddeco force-pushed the misc/ns-deploy-example branch from eefe4af to dac09a5 Sep 25, 2019
This is so that the configuration is not effected by e.g. a namespace
context set in the `kubectl` config of the user, as this caused
problems during the creation of the `ClusterRoleBinding` which was set
to the `default` namespace, while the resources themselves would be
created in the user their configured namespace.

It also simplifies the 'Get started with Kustomize' guide, as a user
does no longer need to create the namespace as a prerequisite but is
still able to overwrite it by adding a `namespace: <targetNamespace>`
to their `kustomization.yaml`.
@hiddeco hiddeco force-pushed the misc/ns-deploy-example branch from dac09a5 to bdb197e Sep 25, 2019
Copy link
Member

stefanprodan left a comment

LGTM

@hiddeco hiddeco merged commit bf83c71 into master Sep 25, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: helm Your tests passed on CircleCI!
Details
@hiddeco hiddeco deleted the misc/ns-deploy-example branch Sep 25, 2019
@hiddeco hiddeco added this to the 1.15.0 milestone Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.