diff --git a/cmd/flux/events.go b/cmd/flux/events.go index 0d467dafca..299d4c4af2 100644 --- a/cmd/flux/events.go +++ b/cmd/flux/events.go @@ -95,8 +95,7 @@ func eventsCmdRun(cmd *cobra.Command, args []string) error { ctx, cancel := context.WithTimeout(context.Background(), rootArgs.timeout) defer cancel() - err := validateEventTypes(eventArgs.filterTypes) - if err != nil { + if err := validateEventTypes(eventArgs.filterTypes); err != nil { return err } @@ -112,9 +111,6 @@ func eventsCmdRun(cmd *cobra.Command, args []string) error { var diffRefNs bool clientListOpts := []client.ListOption{client.InNamespace(*kubeconfigArgs.Namespace)} - if err != nil { - return err - } var refListOpts [][]client.ListOption if eventArgs.forSelector != "" { kind, name := getKindNameFromSelector(eventArgs.forSelector) @@ -163,8 +159,7 @@ func eventsCmdRun(cmd *cobra.Command, args []string) error { return nil } headers := getHeaders(showNamespace) - err = printers.TablePrinter(headers).Print(cmd.OutOrStdout(), rows) - return err + return printers.TablePrinter(headers).Print(cmd.OutOrStdout(), rows) } func getRows(ctx context.Context, kubeclient client.Client, clientListOpts []client.ListOption, refListOpts [][]client.ListOption, showNs bool) ([][]string, error) { @@ -198,8 +193,7 @@ func addEventsToList(ctx context.Context, kubeclient client.Client, el *corev1.E err := runtimeresource.FollowContinue(listOpts, func(options metav1.ListOptions) (runtime.Object, error) { newEvents := &corev1.EventList{} - err := kubeclient.List(ctx, newEvents, clientListOpts...) - if err != nil { + if err := kubeclient.List(ctx, newEvents, clientListOpts...); err != nil { return nil, fmt.Errorf("error getting events: %w", err) } el.Items = append(el.Items, newEvents.Items...) @@ -250,8 +244,7 @@ func eventsCmdWatchRun(ctx context.Context, kubeclient client.WithWatch, listOpt hdr = getHeaders(showNs) firstIteration = false } - err = printers.TablePrinter(hdr).Print(os.Stdout, [][]string{rows}) - if err != nil { + if err = printers.TablePrinter(hdr).Print(os.Stdout, [][]string{rows}); err != nil { return err } @@ -264,8 +257,7 @@ func eventsCmdWatchRun(ctx context.Context, kubeclient client.WithWatch, listOpt return err } go func() { - err := receiveEventChan(ctx, refEventWatch, handleEvent) - if err != nil { + if err := receiveEventChan(ctx, refEventWatch, handleEvent); err != nil { logger.Failuref("error watching events: %s", err.Error()) } }() @@ -331,22 +323,21 @@ func getObjectRef(ctx context.Context, kubeclient client.Client, ref refInfo, na Name: name, } - err := kubeclient.Get(ctx, objName, obj) - if err != nil { + if err := kubeclient.Get(ctx, objName, obj); err != nil { return nil, err } - var ok bool refKind := ref.kind if refKind == "" { kindField := append(ref.field, "kind") - refKind, ok, err = unstructured.NestedString(obj.Object, kindField...) + specKind, ok, err := unstructured.NestedString(obj.Object, kindField...) if err != nil { return nil, err } if !ok { return nil, fmt.Errorf("field '%s' for '%s' not found", strings.Join(kindField, "."), objName) } + refKind = specKind } nameField := append(ref.field, "name")