[RFC-0008] Custom Event Metadata from Annotations #4809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheuscscp
commented
May 23, 2024
|
This is great! Thanks again for picking this up, @matheuscscp 🎉 ! I have nothing to add. It explains the use case very well. Regarding the API group, I don't know enough about the benefits of implementing the |
matheuscscp
force-pushed
the
rfc-7-custom-event-metadata
branch
2 times, most recently
from
6d5ee27 to
14079bc
Compare
darkowlzz
reviewed
Jun 13, 2024
stefanprodan
changed the title
darkowlzz
reviewed
Jun 13, 2024
matheuscscp
force-pushed
the
rfc-7-custom-event-metadata
branch
from
a2c7092 to
f9571f8
Compare
matheuscscp
force-pushed
the
rfc-7-custom-event-metadata
branch
4 times, most recently
from
7b62750 to
0928016
Compare
matheuscscp
force-pushed
the
rfc-7-custom-event-metadata
branch
2 times, most recently
from
51936fa to
ad059ae
Compare
stefanprodan
approved these changes
Jul 17, 2024
darkowlzz
reviewed
Jul 25, 2024
matheuscscp
force-pushed
the
rfc-7-custom-event-metadata
branch
from
ad059ae to
e338913
Compare
stefanprodan
reviewed
Oct 3, 2024
stefanprodan
reviewed
Oct 3, 2024
|
I would love to see this RFC merged. Is there anything I can do ? Also for the implementation. Who's gonna make it ? I am interested to help with my low-level Go skills. :) Thanks |
Hi @benoittgt! Thanks for reaching out! I'm working on this RFC. I'm on vacations this week, but I will pick up the pace next week :) Stay tuned! |
makkes
reviewed
Dec 17, 2024
matheuscscp
force-pushed
the
rfc-7-custom-event-metadata
branch
from
052da50 to
1768ecf
Compare
stefanprodan
changed the title
darkowlzz
reviewed
Dec 18, 2024
matheuscscp
force-pushed
the
rfc-7-custom-event-metadata
branch
2 times, most recently
from
4763c5b to
a71d0b7
Compare
matheuscscp
force-pushed
the
rfc-7-custom-event-metadata
branch
2 times, most recently
from
c546fa7 to
73d23f1
Compare
darkowlzz
reviewed
Dec 23, 2024
matheuscscp
force-pushed
the
rfc-7-custom-event-metadata
branch
from
73d23f1 to
b81f480
Compare
stefanprodan
requested changes
Dec 24, 2024
matheuscscp
force-pushed
the
rfc-7-custom-event-metadata
branch
4 times, most recently
from
cd45381 to
820476b
Compare
1 task
matheuscscp
force-pushed
the
rfc-7-custom-event-metadata
branch
2 times, most recently
from
684d677 to
8492711
Compare
stefanprodan
approved these changes
Jan 7, 2025
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
matheuscscp
force-pushed
the
rfc-7-custom-event-metadata
branch
from
8492711 to
83c16f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This RFC comes as a response to the need for adding custom metadata to events about Flux objects
sent to notification providers.
When a Flux controller sends events about Flux objects, we propose sending annotation keys prefixed with the well-defined API Group
event.toolkit.fluxcd.iofollowed by a slash, i.e. prefixed withevent.toolkit.fluxcd.io/, in addition to all the metadata that is already sent by the controller.