New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Gitlab provider #36
Conversation
e81b3f1
to
18e1123
Compare
@dinosk we need to change the client options and allow setting a different hostname for SSH, please see fluxcd/flux2#171 |
18e1123
to
a4f925e
Compare
b537af9
to
a590802
Compare
added an |
a3b1cc4
to
6db6268
Compare
552073a
to
b6da20c
Compare
gitlab/integration_test.go
Outdated
testRepoName string = "testrepo" | ||
testOrgName string = "GGPGroup" | ||
testSubgroupName string = "ggpsub" | ||
testTeamName string = "GGPGroup2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make a note here about which of these are expected to already exist vs. will be created
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comment.
|
||
const ( | ||
// DefaultDomain specifies the default domain used as the backend. | ||
DefaultDomain = "gitlab.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems to need the https://
prefix to work w/ other domains.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But as we're not really passing scheme around maybe the NewClient should append it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment.
Works! sans the caching request, our gitlab instance doesn't support that.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Closing this, opened #51 to run the integration tests |
Adds a Gitlab provider based on the one for github.
The mapping between Github and Gitlab entities: