This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
e2e: fix flakiness of various tests #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hiddeco fix this typo also |
This ensures that the cleanup of clusters also happens when the creation of one of the clusters fails, as otherwise manual removal is required before the tests can be run again.
The `HELM_VERSION` environmental variable is only used when the flag has not been modified. Due to the default `helm.versions` value in the Helm chart's `values.yaml`, the flag is always modified when the Helm operator is installed using Helm and the environmental value is thus ignored. This commit sets the `helm.versions` flag when installing the operator for end-to-end tests instead of the `HELM_VERSION`, so that the correct Helm version is targeted for e.g. Helm v3 specific tests.
Since the timeout is per package and not per test, set it to a generous 5m instead of 60s.
hiddeco
changed the title
stefanprodan
approved these changes
Jan 7, 2020
2opremio
reviewed
Jan 8, 2020
| @@ -37,15 +37,20 @@ E2E_KIND_CLUSTER_NUM=${E2E_KIND_CLUSTER_NUM:-1} | |||
| if ! kubectl version > /dev/null 2>&1; then | |||
| install_kind | |||
|
|
|||
| # We require GNU Parallel, but some systems come with Tollef's parallel (moreutils) | |||
| if ! parallel -h | grep -q "GNU Parallel"; then | |||
There was a problem hiding this comment.
We should include this in Flux too
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the stability of the end-to-end tests by fixing the flakiness of various tests. In addition, to help (new) contributors with the setup of the end-to-end tests a check has been added to confirm the
parallelversion on the system is GNU Parallel and not Tollef'sparallel, as they behave differently.