This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
release: support skipping CRD installations for Helm v3 #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefansedich
commented
Feb 11, 2020
stefansedich
commented
Feb 11, 2020
pkg/release/release.go
Outdated
| @@ -208,6 +208,7 @@ func (r *Release) Sync(client helm.Client, hr *v1.HelmRelease) (rHr *v1.HelmRele | |||
| ResetValues: hr.Spec.ResetValues, | |||
| MaxHistory: hr.GetMaxHistory(), | |||
| Wait: hr.Spec.Wait || (curRel != nil && hr.Spec.Rollback.Enable), | |||
| SkipCRDs: hr.Spec.SkipCRDs, | |||
There was a problem hiding this comment.
@hiddeco I know you are a stickler for ordering of the properties so let me know if you want it moved 😄
There was a problem hiding this comment.
Haha, I'd probably have done something like this:
...
Install: curRel == nil,
Force: hr.Spec.ForceUpgrade,
ResetValues: hr.Spec.ResetValues,
SkipCRDs: hr.Spec.SkipCRDs,
MaxHistory: hr.GetMaxHistory(),
...There was a problem hiding this comment.
Done, reordered in the CRD too.
stefansedich
commented
Feb 11, 2020
| #!/usr/bin/env bats | ||
|
|
||
| function setup() { | ||
| # Load libraries in setup() to access BATS_* variables |
There was a problem hiding this comment.
Copying and pasting e2e to get going makes me feel dirty... I will have a look at what common stuff we can extract out at some point to make it easier to get started.
stefansedich
commented
Feb 11, 2020
| version: 1.1.1 | ||
| values: | ||
| ingressController: | ||
| installCRDs: false |
There was a problem hiding this comment.
Need to set this so CRDs are not installed by the normal templates.
stefansedich
force-pushed
the
skip-crds-support
branch
2 times, most recently
from
71b74fa
to
250226b
Compare
hiddeco
reviewed
Feb 11, 2020
pkg/release/release.go
Outdated
| @@ -208,6 +208,7 @@ func (r *Release) Sync(client helm.Client, hr *v1.HelmRelease) (rHr *v1.HelmRele | |||
| ResetValues: hr.Spec.ResetValues, | |||
| MaxHistory: hr.GetMaxHistory(), | |||
| Wait: hr.Spec.Wait || (curRel != nil && hr.Spec.Rollback.Enable), | |||
| SkipCRDs: hr.Spec.SkipCRDs, | |||
There was a problem hiding this comment.
Haha, I'd probably have done something like this:
...
Install: curRel == nil,
Force: hr.Spec.ForceUpgrade,
ResetValues: hr.Spec.ResetValues,
SkipCRDs: hr.Spec.SkipCRDs,
MaxHistory: hr.GetMaxHistory(),
...
stefansedich
force-pushed
the
skip-crds-support
branch
from
250226b
to
c32fb29
Compare
hiddeco
changed the title
hiddeco
added
enhancement
stefansedich
force-pushed
the
skip-crds-support
branch
from
c32fb29
to
d1578f5
Compare
hiddeco
approved these changes
Feb 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for
skipCRDsfor helm3 to allow a user to skip CRD installation if desired.@hiddeco I used the same release from the original issue for my e2e test, not sure we want this dependency on the kong chart so let me know if that is an issue.
Closes #278