From c84fbaec37944e58a3f2c42c956dd4585d783fdf Mon Sep 17 00:00:00 2001 From: Hidde Beydals Date: Mon, 30 Sep 2019 13:57:37 +0200 Subject: [PATCH] Make `OwnedByHelmRelease` default to `true` To work around an edge case scenarios some users have reported where the release manifest does not result in any resources (or they are all skipped), and the `HelmRelease` is therefore falsely marked as 'not being owned by'. This should all be refactored to an `ownerReference`, so that we can make use of Kubernetes' garbage collection functionalities[1] and no longer reinvent the wheel. [1]: https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/#owners-and-dependents --- pkg/release/release.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/release/release.go b/pkg/release/release.go index 29cbd4495..e40dfeffa 100644 --- a/pkg/release/release.go +++ b/pkg/release/release.go @@ -344,7 +344,7 @@ func (r *Release) OwnedByHelmRelease(release *hapi_release.Release, hr helmfluxv } } - return false + return true } // annotateResources annotates each of the resources created (or updated)