Unhandled error

[dholbach]

From Ada Logics:

Unhandled error in the image-automation controller, despite the error being assigned to a variable, which can lead to undefined behaviour.

image-automation-controller/controllers/imageupdateautomation_controller.go

Lines 290 to 293 in 674f833

	var signingEntity *openpgp.Entity
	if gitSpec.Commit.SigningKey != nil {
	signingEntity, err = r.getSigningEntity(ctx, auto)
	}

Recommendation
We propose to change the above code to the following:

var signingEntity *openpgp.Entity
if gitSpec.Commit.SigningKey != nil {
    if signingEntity, err = r.getSigningEntity(ctx, auto); err != nil {
        failWithError(err)
    }
}