Missing return statement after error

[dholbach]

From Ada Logics

In the Image-automation reconciler an issue is present where the code continues after an error occurs, leading to undefined behaviour:

image-automation-controller/controllers/imageupdateautomation_controller.go

Lines 204 to 211 in 674f833

	// Here's where it gets constrained. If there's no push branch
	// given, then the checkout ref must include a branch, and
	// that can be used.
	if ref == nil || ref.Branch == "" {
	return failWithError(fmt.Errorf("Push branch not given explicitly, and cannot be inferred from .spec.git.checkout.ref or GitRepository .spec.ref"))
	}
	pushBranch = ref.Branch
	tracelog.Info("using push branch from $ref.branch", "branch", pushBranch)

The problem is that the failWithError branch does not itself return from the reconcile function and the code should instead be return failWithError

Recommendation

Change the code to return failWithError

[relu]

Fixed in 5a831a8.