Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File extensions comparisons are case sensitive #476

Closed
dholbach opened this issue Oct 27, 2021 · 1 comment
Closed

File extensions comparisons are case sensitive #476

dholbach opened this issue Oct 27, 2021 · 1 comment
Assignees
Labels
wontfix This will not be worked on

Comments

@dholbach
Copy link
Member

From Ada Logics

In the lines

extension := filepath.Ext(path)
if extension != ".yaml" && extension != ".yml" {
return nil
}

A check happens on the file extension for YAML files

However, the check is case sensitive. We recommend either documenting this or allowing file extensions that are not purely limited to lowercase extensions.

Recommendation
Normalise file extensions when processing them to allow uppercase letters in extensions or clarify that files must be lowercase.

@relu relu self-assigned this Nov 4, 2021
@relu
Copy link
Member

relu commented Nov 4, 2021

Looking at the kustomize source code, it seems the list of recognized files only accounts for the lowercase variant.
I wasn't able to find any user-oriented documentation regarding this convention.

Given there's no support upstream for upper or mixed-case variants of the file extension I think it's safe to close this as "won't fix".

@relu relu closed this as completed Nov 4, 2021
@relu relu added the wontfix This will not be worked on label Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants