x509 certificates are not used for Webex

[dholbach]

From Ada Logics

In the alert-controller the Webex hook takes an x509 certificate as argument but does not use it here:

notification-controller/internal/notifier/webex.go

Lines 42 to 52 in 8ff5f75

	func NewWebex(hookURL, proxyURL string, certPool *x509.CertPool) (*Webex, error) {
	_, err := url.ParseRequestURI(hookURL)
	if err != nil {
	return nil, fmt.Errorf("invalid Webex hook URL %s", hookURL)
	}
	return &Webex{
	URL: hookURL,
	ProxyURL: proxyURL,
	}, nil
	}

This is despite the certPool being used by the Webex notifier here:

notification-controller/internal/notifier/webex.go

Lines 76 to 78 in 8ff5f75

	if err := postMessage(s.URL, s.ProxyURL, s.CertPool, payload); err != nil {
	return fmt.Errorf("postMessage failed: %w", err)
	}

Recommendation
Ensure certificate is used or clarify why it is not.