Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for custom certs in HelmRepositories of Type oci #723

Closed
souleb opened this issue May 16, 2022 · 7 comments · Fixed by #1097
Closed

Add support for custom certs in HelmRepositories of Type oci #723

souleb opened this issue May 16, 2022 · 7 comments · Fixed by #1097
Assignees
@souleb
Labels
area/helm Helm related issues and pull requests area/oci OCI related issues and pull requests enhancement New feature or request
Milestone
Helm GA

Comments

@souleb
Copy link
Member

souleb commented May 16, 2022 •
edited
Loading

Currently the HTTP/S HelmRepository type support passing a secret containing certFile, keyFile, and caFile. A TLSConfig is built from it and passed downstream to the roundtripper.

This issue is about adding this feature for OCI HelmRepository type.
@souleb souleb self-assigned this May 16, 2022
@souleb souleb added enhancement New feature or request area/helm Helm related issues and pull requests labels May 16, 2022
@souleb souleb mentioned this issue May 16, 2022
Merged
6 tasks
@makkes makkes added the area/oci OCI related issues and pull requests label May 23, 2022
@souleb
Copy link
Member Author

souleb commented Jun 8, 2022

on-going oras-project/oras-go#171

@stefanprodan
Copy link
Member

@souleb I see that your PR has been merged, what else is needed?

@souleb
Copy link
Member Author

souleb commented Aug 12, 2022

I need to adapt the getter on helm side... I am currently testing the implementation.

@souleb
Copy link
Member Author

souleb commented Nov 22, 2022 •
edited
Loading

The pr is submitted on helm side. helm/helm#11363.

Helm maintainers have been testing it for some time now. They are confident it will be merged.

@souleb souleb added this to the GA milestone Nov 22, 2022
@kingdonb kingdonb mentioned this issue Dec 22, 2022
Closed
1 task
@souleb
Copy link
Member Author

souleb commented Mar 14, 2023 •
edited
Loading

The work on upstream has been merged in main. The target release is 3.12.0 (next minor). See helm/helm#11711

We can now start the implementation work.

@souleb souleb mentioned this issue May 16, 2023
Merged
@pefeigl
Copy link

pefeigl commented May 24, 2023

Is there any estimate on when support for this might arrive in a release?
Thanks for any information ;)

@mfilotto
Copy link

@pefeigl FYI we're using this workaround: fluxcd/flux2#3417 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@souleb souleb

Labels
area/helm Helm related issues and pull requests area/oci OCI related issues and pull requests enhancement New feature or request
Projects
None yet
Milestone
Helm GA
Development

Successfully merging a pull request may close this issue.

Helm OCI: Add support for TLS registries with self-signed certs souleb/source-controller
5 participants
@makkes @stefanprodan @mfilotto @souleb @pefeigl