storage: change default file permissions #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
added
enhancement
hiddeco
force-pushed
the
default-file-perms
branch
from
7649479
to
1a27148
Compare
|
@rashedkvm can you please confirm this does not create any issues with your usage of source-controller? |
hiddeco
force-pushed
the
default-file-perms
branch
from
df7444d
to
b8f9184
Compare
rashedkvm
reviewed
Nov 4, 2023
There was a problem hiding this comment.
@hiddeco this changes restricts group and public permission for file/directory/exe. Owner permission remain unchanged. I can't think of any issue at the moment. If you need to get this change in quickly, please proceed. Alternatively, I can test this change but requires sometime.
hiddeco
force-pushed
the
default-file-perms
branch
from
b8f9184
to
67bf9ad
Compare
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
hiddeco
force-pushed
the
default-file-perms
branch
from
67bf9ad
to
add7568
Compare
hiddeco
force-pushed
the
default-file-perms
branch
from
add7568
to
b84cf80
Compare
hiddeco
commented
Nov 6, 2023
| k8s.io/api v0.27.4 | ||
| k8s.io/apimachinery v0.27.4 | ||
| k8s.io/client-go v0.27.4 | ||
| k8s.io/api v0.27.7 |
There was a problem hiding this comment.
Remainder should be done in a separate PR, as this one is just about the storage changes.
As this includes an update of ORAS compatible with newer versions of `github.com/docker/docker`, we can unpin this dependency. Signed-off-by: Hidde Beydals <hidde@hhh.computer>
stefanprodan
approved these changes
Nov 6, 2023
hiddeco
force-pushed
the
default-file-perms
branch
from
b84cf80
to
57e829f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.