Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase brightness + reduced reflections #6968

Merged
merged 2 commits into from
Mar 26, 2022
Merged

Conversation

Saschl
Copy link
Contributor

@Saschl Saschl commented Mar 25, 2022

Credits to our modelers

Fixes #[issue_no]

Summary of Changes

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

  • Make sure displays are not unreadable in bright conditions.
  • Check if the reflection effect still looks fine.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@Saschl Saschl closed this Mar 25, 2022
@Saschl Saschl reopened this Mar 25, 2022
Copy link
Contributor

@NUTTTTTTTT NUTTTTTTTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sidnov sidnov added Displays ata-31-displays Extensive Testing Needed More testing needed in this PR QA Tier 1 labels Mar 25, 2022
@Watsi01
Copy link
Contributor

Watsi01 commented Mar 25, 2022

Made a quick testride. I would increase it even a bit further (by one or two). Sid is also checking it. Let's see what he says.

@sidnov
Copy link
Member

sidnov commented Mar 25, 2022

Daytime- Max brightness is just enough to be the middle ground between good sim experience and IRL lighting characteristics
Night- Ideal brightness, max is enough to overexpose some sections of the PFD due to the sim's bloom effect, but that also results in a beautiful backlight effect.
Reflection- Mitigated, the excessive gloss is gone and it is received well by the eye.

image
image
image
image
image
image

Low brightness issue for me is more prominent on smaller displays (1080p, 15.6in Laptop display)

@johnpmaguire
Copy link
Contributor

Quality Assurance Tester Report

Discord :
Object of testing: increase brightness + reduced reflections #6968
Tier of Testing : 2
Date : 26/03/2022

Testing Process:
Completed full flights from stand to stand checking various lighting and weather conditions in daylight both for 2D and VR.

Notes. I think I have a very good setup. I fly at ultra on large 4k displays. The PFD is 16cm diagonally on the screen from normal viewing position. This makes viewing the displays clear. In VR mostly high with a some ultra using a quest 2.

The reflections are subdued, a good change from me. PFD ND at 1-2 o'clock brightness was the best balance for me. The ECAM displays were set to a higher brightness almost at maximum. I set up the flight to enter and leave clouds. No change was necessary to read the displays.

Looking out the left window and back to the displays was fine in VR and 2D.

Negatives:
None noted

Testing Results:
Passed, I prefer to see less of the reflections.

Conclusions:
LGTM. With a caveat. The number of variations in display hardware, settings and seating position makes this a subjective test. It looked fine on my setup. I think I have all the settings tuned to give me the best display for my system. Other users will have varying improvements and opinions depending on their set-up.

image

@sidnov sidnov merged commit f6da53d into master Mar 26, 2022
Lucky38i pushed a commit that referenced this pull request Apr 1, 2022
* fix: increase brightness + reduced reflections

Credits to our modelers

* fix: improve MCDU brightness

Co-authored-by: Siddharth S <sidnov@yahoo.co.in>
ErickSharp pushed a commit that referenced this pull request Apr 3, 2022
* fix: increase brightness + reduced reflections

Credits to our modelers

* fix: improve MCDU brightness

Co-authored-by: Siddharth S <sidnov@yahoo.co.in>
@aguther aguther deleted the fix/brightness branch April 15, 2022 07:59
@2hwk 2hwk added this to the v0.8.0 milestone Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Displays ata-31-displays Extensive Testing Needed More testing needed in this PR QA Tier 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants