Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JSCS #1024

Closed
lunaryorn opened this issue Jul 29, 2016 · 7 comments · Fixed by #1370
Closed

Remove JSCS #1024

lunaryorn opened this issue Jul 29, 2016 · 7 comments · Fixed by #1370

Comments

@lunaryorn
Copy link
Contributor

@lunaryorn lunaryorn commented Jul 29, 2016

JSCS has reached end of life, we should stop supporting it as well.

/cc @flycheck/javascript

Edit: For reference, the compatibility milestone

@Simplify
Copy link
Member

@Simplify Simplify commented Jul 29, 2016

On the same page:

We have setup a milestone for tracking all of our JSCS compatibility issues. At the time of this post, we are at 20% complete and are continuing to make progress.

And:

We recommend holding off on switching from JSCS to ESLint until most of the compatibility work has been completed (we will make an announcement when that happens).

I'll wait until that announcement. JSCS still have 27000+ downloads every day, around same number as in April when they announced joining ESLint.

@lunaryorn
Copy link
Contributor Author

@lunaryorn lunaryorn commented Jul 29, 2016

@Simplify We can wait, but I'd not like to prolong cleanup work beyond what's absolutely necessary. Users who still need JSCS can either restore the definition, or stick to an older Flycheck release.

@Simplify Simplify self-assigned this Jul 29, 2016
@Simplify
Copy link
Member

@Simplify Simplify commented Jul 29, 2016

Ok, give me few days to check few things that JSCS did better than ESLint, for example checking JSDoc comments in the code.

@Simplify
Copy link
Member

@Simplify Simplify commented Jul 29, 2016

We can also extract JSCS in gist.

@lunaryorn
Copy link
Contributor Author

@lunaryorn lunaryorn commented Jul 29, 2016

@Simplify As I said, we can wait until eslint provides full compatibility, but as soon as that's the case, we'll remove JSCS.

@Simplify
Copy link
Member

@Simplify Simplify commented Sep 1, 2016

@lunaryorn Just a quick update: Compatibility is now at 38% and there is a draft of JSCS migration guide. However, there are still around 30K downloads of JSCS every day.

I'm busy next 2 weeks, but after that we can check status again. Maybe we can wait until compatibility hits 60-80% or that migration guide is done. Doe to high number of downloads, the best solution IMHO is to extract JSCS checker into GH gist, then people can load that file into Emacs if they still need JSCS support. Maybe provide link to that gist in ChangeLog.

@Simplify
Copy link
Member

@Simplify Simplify commented Dec 6, 2017

@fmdkdd fmdkdd closed this in #1370 Dec 6, 2017
fmdkdd added a commit that referenced this issue Dec 6, 2017
GH-1024 - Remove javascript-jscs checker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants