New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding TSLint checker into standard Flycheck #947

Closed
Simplify opened this Issue Apr 19, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@Simplify
Member

Simplify commented Apr 19, 2016

Hello,

I'm author and maintainer of flycheck-typescript-tslint package. I'll like to include that code into standard Flyckeck, if you want that. I try to contact you about that on Gitter, but didn't got any reply.

TSLint is currently standard for linting TypeScript. Config for TSLint, tslint.json, is comes with most TypeScript projects and it's included with angular2-quickstart. I think that having this as standard is Flycheck would be great. If you agree, I'll try make PR in the coming days, including tests and documentation. Even I use GNU Emacs for more than 10 years, I'm new to Elisp, so please be critical :)

One another thing worth mentioning is that ESLint, checker for JavaScript, have experimental extension for TypeScript.

@cpitclaudel

This comment has been minimized.

Member

cpitclaudel commented Apr 19, 2016

Hey @Simplify,

Thanks for contributing! Yes, I think we'd love to include support for TSLint. Can you prepare a pull request?

@Simplify

This comment has been minimized.

Member

Simplify commented Apr 19, 2016

Yes, I'll do it in the next few days.

@cpitclaudel

This comment has been minimized.

Member

cpitclaudel commented Apr 19, 2016

Thanks!

@lunaryorn

This comment has been minimized.

Contributor

lunaryorn commented Apr 19, 2016

@Simplify Thank you very very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment