New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jade is now called pug (trademark problem)-- we should probably fix it so flycheck works #951

Closed
robbyoconnor opened this Issue Apr 30, 2016 · 19 comments

Comments

Projects
None yet
4 participants
@robbyoconnor
Contributor

robbyoconnor commented Apr 30, 2016

I'm gonna take this on but is there a way to handle this in a way that doesn't break the current jade support?

@cpitclaudel

This comment has been minimized.

Member

cpitclaudel commented Apr 30, 2016

I take it you're referring to pugjs/pug#2184?

@lunaryorn will confirm, but I think we can just add a separate pug checker to Flycheck with the same definition as the jade one (but predicated on pug-mode — I imagine that's what the Emacs mode will be renamed to). Once the pug→jade transition is complete we'll deprecate the jade checker.

We generally don't have too much compatibility stuff like this, but I'd vote for making an exception on this one given the exceptionally annoying process the Jade people are being forced to go through for silly reasons.

@lunaryorn

This comment has been minimized.

Contributor

lunaryorn commented Apr 30, 2016

@robbyoconnor Thank you for making us aware of this issue, but please provide more background information. We simply cannot follow all developments in all the languages that we support.

What is the current status of jade? Is it renamed already, with a proper release, or is the rename still ongoing? In how far does the renaming affect us other than that we need to rename the syntax checker? In how far would this break the current support for Jade? Does the renamed version also behave differently?

@robbyoconnor

This comment has been minimized.

Contributor

robbyoconnor commented Apr 30, 2016

@lunaryorn -- as of right now the domain name is registered but the site is very much in progress-- the github org is migrated -- but the emacs major-mode is currently still jade-mode -- This doesn't look like it's gonna be a lot of work to do -- it's looking like more or less they just did a name change removing all traces of Jade/jade. I could fork the jade-mode and force the maintainers hand -- or wait until he does...honestly -- jade-mode works fine -- but flycheck is nice to have.

@lunaryorn

This comment has been minimized.

Contributor

lunaryorn commented Apr 30, 2016

@robbyoconnor I'm sorry but I'm still not sure in how far this affects us, nor why it could break Flycheck.

Presuming that pug still has the same CLI interface as jade, wouldn't it be sufficient to just rename the syntax checker to pug, make it run pug instead of jade and add a (yet to come?) pug-mode to its :modes?

That's something we could do as soon as the tool is officially renamed, though not before, to avoid confusion.

@robbyoconnor

This comment has been minimized.

Contributor

robbyoconnor commented Apr 30, 2016

That is one option but there is still code out there that's running jade -- or completely unaware this happened. That is my concern...I mean currently it's broken for one group regardless

@lunaryorn

This comment has been minimized.

Contributor

lunaryorn commented Jun 2, 2016

@robbyoconnor What's the status of this?

@robbyoconnor

This comment has been minimized.

Contributor

robbyoconnor commented Jun 2, 2016

I was waiting to hear back on what I should do...supporting both sounds
like a lot of work...maybe I'll just support pug?

--Rob
Sent from my cell, please excuse any typos.
On Jun 2, 2016 2:18 PM, "Sebastian Wiesner" notifications@github.com
wrote:

@robbyoconnor https://github.com/robbyoconnor What's the status of this?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#951 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AABaMF4H6D4zO7kYhUnsH9NQ5WoIs07rks5qHx5ogaJpZM4ITVAQ
.

@lunaryorn

This comment has been minimized.

Contributor

lunaryorn commented Jun 2, 2016

Ah sorry. Yes, well only support pug imho. Let's keep things simple ☺️

Is the rename complete already?

@robbyoconnor

This comment has been minimized.

Contributor

robbyoconnor commented Jun 4, 2016

I believe so -- give me a couple day? I'll reference this issue in my PR
On 06/02/2016 05:08 PM, Sebastian Wiesner wrote:

Ah sorry. Yes, well only support pug imho. Let's keep things simple ☺️

Is the rename complete already?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#951 (comment), or
mute the thread
https://github.com/notifications/unsubscribe/AABaMPPo2dUL7jeVMiyIbLP_MDt-zvb6ks5qH0ZngaJpZM4ITVAQ.

@cpitclaudel

This comment has been minimized.

Member

cpitclaudel commented Jun 4, 2016

@robbyoconnor Perfect, thanks!

@lunaryorn

This comment has been minimized.

Contributor

lunaryorn commented Jul 15, 2016

@robbyoconnor Any news here? Did you get a chance to work on renaming Jade to Pug in Flycheck?

@nickmccurdy

This comment has been minimized.

nickmccurdy commented Sep 10, 2016

Pug 2 was released in August, which I believe is the first official renamed release. I'm also interesting in progress on this, does anyone want help?

@robbyoconnor

This comment has been minimized.

Contributor

robbyoconnor commented Sep 11, 2016

I'll do this tonight. Sorry folks -- resigned from a role that sucked the life out of me -- gonna move on this! Sorry all.

@nickmccurdy

This comment has been minimized.

nickmccurdy commented Sep 11, 2016

No rush. 😄 I was just curious if you guys were aware of the release, I think it was a prerelease for a while.

@cpitclaudel

This comment has been minimized.

Member

cpitclaudel commented Sep 11, 2016

Thanks @robbyoconnor :) And good luck with work! No apologies needed.

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 11, 2016

@robbyoconnor

This comment has been minimized.

Contributor

robbyoconnor commented Sep 11, 2016

Still testing, will make a PR after I'm sure this works. We should also look into adding pug-lint support, I'm willing to take this on in a separate PR.

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 11, 2016

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 11, 2016

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 11, 2016

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 12, 2016

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 12, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

This commit also added f as a dependency to `Cask` to make the format
make task run.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 12, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

This commit also added f as a dependency to `Cask` to make the format
make task run.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 12, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

This commit also added f as a dependency to `Cask` to make the format
make task run.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 12, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

This commit also added f as a dependency to `Cask` to make the format
make task run.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 12, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

This commit also added f as a dependency to `Cask` to make the format
make task run.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 12, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

This commit also added f as a dependency to `Cask` to make the format
make task run.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 12, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 12, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 14, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 14, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 14, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 14, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 15, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 15, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 15, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 15, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 15, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 15, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 15, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 15, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 15, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 15, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 15, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 15, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 15, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 15, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 15, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 15, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

Closes flycheckGH-951

robbyoconnor added a commit to robbyoconnor/flycheck that referenced this issue Sep 15, 2016

Remove jade checker and replace it with pug checker
Jade is now deprecated and is replaced by pug. I do not feel it is
worth while to maintain a checker for both.

Closes flycheckGH-951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment