Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optionally install golang test dependencies #1003

Merged
merged 1 commit into from Jul 12, 2016

Conversation

jvshahid
Copy link
Contributor

@jvshahid jvshahid commented Jul 5, 2016

use the flycheck-go-build-install-deps flag to optionally install test dependencies. this will improve the time it takes to run flycheck

@swsnr
Copy link
Contributor

swsnr commented Jul 6, 2016

@flycheck/go Could you take a look?

@@ -6747,7 +6747,7 @@ See URL `http://golang.org/cmd/go'."
;; `temporary-file-name'.
;; TODO: Switch to `null-device'` when < Go 1.6 support is removed.
;; See: https://github.com/flycheck/flycheck/issues/838
:command ("go" "test" "-c" "-o" temporary-file-name)
:command ("go" "test" (option-flag "-i" flycheck-go-build-install-deps) "-c" "-o" temporary-file-name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wrap this line, it's too long. Put the (option-flag …) part on a separate line, and the arguments after it on another separator line.

@jvshahid
Copy link
Contributor Author

jvshahid commented Jul 6, 2016

@lunaryorn done

@dominikh
Copy link
Member

dominikh commented Jul 6, 2016

LGTM

@swsnr
Copy link
Contributor

swsnr commented Jul 6, 2016

@jvshahid Please add a note about this change to CHANGES.rst and update the documentation of this option in doc/languages.rst 😊

@jvshahid
Copy link
Contributor Author

jvshahid commented Jul 6, 2016

now that i'm looking at the code again, should the name of the option be flycheck-go-build-install-deps or have test in it, i.e. flycheck-go-test-install-deps ?

@jvshahid
Copy link
Contributor Author

jvshahid commented Jul 6, 2016

pushed the change to the docs. let me know if i should create a separate option for go-test

@@ -379,7 +379,8 @@ to view the docstring of the syntax checker. Likewise, you may use

.. option:: flycheck-go-build-install-deps

Whether to install dependencies while checking.
Whether to install dependencies while checking. **Note** this option
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better write … while checking with go-buildorgo-test.

@swsnr
Copy link
Contributor

swsnr commented Jul 7, 2016

@jvshahid Some minor issues with the docs are left. Please address these, then rebase onto current master and squash your commits. Thank you :)

@jvshahid
Copy link
Contributor Author

jvshahid commented Jul 7, 2016

@lunaryorn thanks for reviewing the pr. all requested changes have been taken care of.

@@ -5,6 +5,8 @@

- Add ``:default-directory`` option to ``flycheck-define-command-checker``
[GH-973]
- ``flycheck-go-build-install-deps`` turn on dependency installation for ``go test``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turn -> turns :)

@swsnr
Copy link
Contributor

swsnr commented Jul 12, 2016

@jvshahid There are a two spelling issues left. Please fix these, and then rebase onto master to resolve the conflict in the changelog.

@jvshahid
Copy link
Contributor Author

@lunaryorn fixed all the typos mentioned above

@@ -6,6 +6,9 @@
- Add ``:working-directory`` option to ``flycheck-define-command-checker``
[GH-973] [GH-1012]

- ``flycheck-go-build-install-deps`` turns on dependency installation for ``go test``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I forgot one thing: Could you please remove the blank line above this line? In ReST there shouldn't be blank lines within lists, only between different nesting levels.

use the `flycheck-go-build-install-deps' flag to optionally install test
dependencies. this will improve the time it takes to run flycheck
@jvshahid
Copy link
Contributor Author

Done

@swsnr
Copy link
Contributor

swsnr commented Jul 12, 2016

LGTM. @cpitclaudel Would you take a look?

@cpitclaudel
Copy link
Member

LGTM. Thanks for this patch!

@swsnr swsnr merged commit a1e7669 into flycheck:master Jul 12, 2016
@swsnr
Copy link
Contributor

swsnr commented Jul 12, 2016

Merged. Thank you very much for this patch 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants