New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a VHDL checker using GHDL #1160

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@dzamlo
Contributor

dzamlo commented Nov 13, 2016

No description provided.

@lunaryorn

This comment has been minimized.

Contributor

lunaryorn commented Nov 14, 2016

@dzamlo Thanks… LGTM, but it will need a couple of refinements.

@lunaryorn

Please add a note about the new checker to CHANGES.rst.

Could you perhaps also add a test case for the new syntax checker to test/flycheck-test.el? Take a look at the other tests for syntax checkers which are at the end of that file…

flycheck.el Outdated
:type '(choice (const :tag "Default standard" nil)
(string :tag "Language standard"))
:safe #'stringp
:package-version '(flycheck . "0.31"))

This comment has been minimized.

@lunaryorn

lunaryorn Nov 14, 2016

Contributor

The version's wrong here. We do not use a leading zero.

flycheck.el Outdated
(flycheck-define-checker vhdl-ghdl
"A VHDL syntax checker using GHDL."
:command ("ghdl"
"-s"

This comment has been minimized.

@lunaryorn

lunaryorn Nov 14, 2016

Contributor

What's -s for? Could you add comment to the source that explains the purpose of the flag?

This comment has been minimized.

@dzamlo

dzamlo Nov 14, 2016

Contributor

It is the flag to do the Syntax-check.

flycheck.el Outdated
:command ("ghdl"
"-s"
(option "--std=" flycheck-ghdl-language-standard concat)
source)

This comment has been minimized.

@lunaryorn

lunaryorn Nov 14, 2016

Contributor

Can GHDL read the source code from standard input?

This comment has been minimized.

@dzamlo

dzamlo Nov 14, 2016

Contributor

No

@dzamlo dzamlo force-pushed the dzamlo:vhdl branch 2 times, most recently from 252f120 to 64bdcc9 Nov 14, 2016

@lunaryorn

This comment has been minimized.

Contributor

lunaryorn commented Nov 17, 2016

@dzamlo Thanks! Could you please squash all your commits into a single one so that we can merge?

@cpitclaudel

This comment has been minimized.

Member

cpitclaudel commented Nov 17, 2016

LGTM too! Thanks for working on this :)

@dzamlo dzamlo force-pushed the dzamlo:vhdl branch from 64bdcc9 to 62b2316 Nov 17, 2016

@dzamlo

This comment has been minimized.

Contributor

dzamlo commented Nov 17, 2016

All my commits have been squashed.

@dzamlo

This comment has been minimized.

Contributor

dzamlo commented Nov 23, 2016

Is there something blocking this pull request ? I thinks that I addressed the requested changes.

@fmdkdd

This comment has been minimized.

Member

fmdkdd commented Jul 17, 2017

@dzamlo Terribly sorry for the delay. Your PR suffered a bad timing with the maintainer retiring.

We'd still like to merge this! Can you rebase on master so we can proceed?

@fmdkdd

This comment has been minimized.

Member

fmdkdd commented Feb 10, 2018

Closing in favor of #1399.

@fmdkdd fmdkdd closed this Feb 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment