Add a VHDL checker using GHDL #1160
Conversation
|
@dzamlo Thanks… LGTM, but it will need a couple of refinements. |
| :type '(choice (const :tag "Default standard" nil) | ||
| (string :tag "Language standard")) | ||
| :safe #'stringp | ||
| :package-version '(flycheck . "0.31")) |
There was a problem hiding this comment.
The version's wrong here. We do not use a leading zero.
| (flycheck-define-checker vhdl-ghdl | ||
| "A VHDL syntax checker using GHDL." | ||
| :command ("ghdl" | ||
| "-s" |
There was a problem hiding this comment.
What's -s for? Could you add comment to the source that explains the purpose of the flag?
There was a problem hiding this comment.
It is the flag to do the Syntax-check.
| :command ("ghdl" | ||
| "-s" | ||
| (option "--std=" flycheck-ghdl-language-standard concat) | ||
| source) |
There was a problem hiding this comment.
Can GHDL read the source code from standard input?
dzamlo
force-pushed
the
vhdl
branch
2 times, most recently
from
252f120
to
64bdcc9
Compare
|
@dzamlo Thanks! Could you please squash all your commits into a single one so that we can merge? |
|
LGTM too! Thanks for working on this :) |
|
All my commits have been squashed. |
|
Is there something blocking this pull request ? I thinks that I addressed the requested changes. |
|
@dzamlo Terribly sorry for the delay. Your PR suffered a bad timing with the maintainer retiring. We'd still like to merge this! Can you rebase on master so we can proceed? |
|
Closing in favor of #1399. |
No description provided.