Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nix checker #1164

Merged
merged 1 commit into from Apr 15, 2017
Merged

Add nix checker #1164

merged 1 commit into from Apr 15, 2017

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Nov 17, 2016

Hi:
I've added checker for nix

make LANGUAGE=nix integ
cask exec emacs -Q --batch -L .  -l maint/flycheck-compile.el -f flycheck/batch-byte-compile flycheck-buttercup.el
cask exec emacs -Q --batch -L .  --load test/flycheck-test --load test/run.el -f flycheck-run-tests-main '(and (tag external-tool) (language nix))'
Running tests on Emacs 26.0.50.1, built at 2016-11-14
Running 1 tests (2016-11-16 20:05:21-0500)
   passed  1/1  flycheck-define-checker/nix/default

Ran 1 tests, 1 results as expected (2016-11-16 20:05:22-0500)

@@ -681,6 +681,14 @@ to view the docstring of the syntax checker. Likewise, you may use

.. syntax-checker-config-file:: flycheck-perlcriticrc

.. supported-language:: Nix

This comment has been minimized.

@lunaryorn

lunaryorn Nov 17, 2016
Contributor

Please keep the list of languages alphabetically sorted—"Nix" should go before "Markdown".

This comment has been minimized.

@cpitclaudel

cpitclaudel Nov 17, 2016
Member

Did you mean after? :)

This comment has been minimized.

@lunaryorn

lunaryorn Nov 17, 2016
Contributor

@cpitclaudel 😊 D'oh, you're right of course :)

/cc @marsam

@lunaryorn
Copy link
Contributor

@lunaryorn lunaryorn commented Nov 17, 2016

LGTM.

@cpitclaudel
Copy link
Member

@cpitclaudel cpitclaudel commented Nov 17, 2016

LGTM too! Thanks for working on this.

@marsam
Copy link
Contributor Author

@marsam marsam commented Nov 17, 2016

Updated :)

marsam added a commit to emacs-pe/nix-mode that referenced this pull request Mar 8, 2017
@jb55 jb55 mentioned this pull request Apr 15, 2017
@jb55
Copy link

@jb55 jb55 commented Apr 15, 2017

anything left to do here? looking forward to this!

@fmdkdd fmdkdd dismissed lunaryorn’s stale review Apr 15, 2017

Latest commit made the requested change

@fmdkdd
Copy link
Member

@fmdkdd fmdkdd commented Apr 15, 2017

It seems this fell under the radar. Thanks for the reminder :)

@marsam Could you rebase on master? And then this should be good to merge.

@marsam
Copy link
Contributor Author

@marsam marsam commented Apr 15, 2017

Rebased

@cpitclaudel cpitclaudel merged commit 2d40aad into flycheck:master Apr 15, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
jb55 added a commit to jb55/spacemacs that referenced this pull request Apr 19, 2017
nix syntax checking with nix-instantiate was just merged into flycheck:

  flycheck/flycheck#1164

This enables flycheck support in nix-mode to the nixos layer.
syl20bnr added a commit to syl20bnr/spacemacs that referenced this pull request Apr 20, 2017
nix syntax checking with nix-instantiate was just merged into flycheck:

  flycheck/flycheck#1164

This enables flycheck support in nix-mode to the nixos layer.
ksonney pushed a commit to ksonney/spacemacs that referenced this pull request Apr 25, 2017
nix syntax checking with nix-instantiate was just merged into flycheck:

  flycheck/flycheck#1164

This enables flycheck support in nix-mode to the nixos layer.
ksonney added a commit to ksonney/spacemacs that referenced this pull request Apr 26, 2017
nix syntax checking with nix-instantiate was just merged into flycheck:

  flycheck/flycheck#1164

This enables flycheck support in nix-mode to the nixos layer.
tranchis added a commit to tranchis/spacemacs that referenced this pull request May 25, 2017
nix syntax checking with nix-instantiate was just merged into flycheck:

  flycheck/flycheck#1164

This enables flycheck support in nix-mode to the nixos layer.
CodingSolo pushed a commit to CodingSolo/spacemacs that referenced this pull request Oct 29, 2018
nix syntax checking with nix-instantiate was just merged into flycheck:

  flycheck/flycheck#1164

This enables flycheck support in nix-mode to the nixos layer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants