Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Asciidoctor as checker for AsciiDoc #1167

Merged

Conversation

fapdash
Copy link
Contributor

@fapdash fapdash commented Nov 18, 2016

I broke make specs but I don't understand the error message. Help would be appreciated.

FAILED: Expected (asciidoctor) to `equal' nil

Ran 98 out of 99 specs, 1 failed, in 3.2 seconds.

@CLAassistant
Copy link

CLAassistant commented Nov 18, 2016

CLA assistant check
All committers have signed the CLA.

@swsnr
Copy link
Contributor

swsnr commented Nov 18, 2016

@fap- Thanks. Could you explain how Asciidoctor is different from the checker we're currently using?

swsnr
swsnr previously requested changes Nov 18, 2016
Copy link
Contributor

@swsnr swsnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document this syntax checker in doc/languages.rst. That's what's making the test fail currently.

@fapdash fapdash force-pushed the 1166-add-asciidoctor-asciidoc-checker branch from 571a1a9 to ac78453 Compare November 18, 2016 08:59
@fapdash
Copy link
Contributor Author

fapdash commented Nov 18, 2016

Asciidoctor adds additional features, syntax and enforces stricter rules.
You can read more about the differences here: Differences between Asciidoctor and AsciiDoc

@swsnr
Copy link
Contributor

swsnr commented Nov 18, 2016

@fap- So it's strictly better than asciidoc itself?

@fapdash
Copy link
Contributor Author

fapdash commented Nov 18, 2016

Since I don't have any experience with AsciiDoc I don't feel qualified to answer that.
The last official release for AsciiDoc seems to be from 2013?
http://www.methods.co.nz/asciidoc/CHANGELOG.html

We use Asciidoctor at work and it gets actively developed and the project leader is very responsive.

adoc-mode seems to support both (haven't run into issues so far) as the syntax seems to be mostly the same.

@swsnr
Copy link
Contributor

swsnr commented Nov 18, 2016

@fap- In that case I'd say it is superior. Could you move it before asciidoc so that it's preferred?

@fapdash fapdash force-pushed the 1166-add-asciidoctor-asciidoc-checker branch from ac78453 to 56b89ee Compare November 18, 2016 16:28
@fapdash
Copy link
Contributor Author

fapdash commented Nov 18, 2016

@lunaryorn I moved the position in (defcustom flycheck-checkers ...) Hope this was the right place?

Edit: also moved Asciidoctor above AsciiDoc in the language doc

@fapdash fapdash force-pushed the 1166-add-asciidoctor-asciidoc-checker branch 2 times, most recently from 25b63e8 to 4b5fbc8 Compare November 18, 2016 20:28
@fapdash
Copy link
Contributor Author

fapdash commented Nov 25, 2016

@lunaryorn Any chance of merging this?

@fapdash
Copy link
Contributor Author

fapdash commented Feb 3, 2017

@flycheck/maintainers I know I've asked before but is there a chance of merging this checker now?
I'd be willing to maintain this recipe going forward. (referencing #1177 (comment))

@fmdkdd fmdkdd dismissed swsnr’s stale review February 4, 2017 10:40

Changes were made as requested

Copy link
Member

@fmdkdd fmdkdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems ready to merge. Thanks for pushing forward with this.

If you could just add a line to CHANGES.rst under 'New syntax checkers', and then I will merge.

@cpitclaudel
Copy link
Member

Indeed, thanks for your work! We'll be happy to merge this, with the right CHANGES entry :)

@fapdash fapdash force-pushed the 1166-add-asciidoctor-asciidoc-checker branch from 4b5fbc8 to b03c73c Compare February 6, 2017 19:30
@fapdash
Copy link
Contributor Author

fapdash commented Feb 6, 2017

Should be done :]

@fmdkdd fmdkdd merged commit bbf5653 into flycheck:master Feb 6, 2017
@fmdkdd
Copy link
Member

fmdkdd commented Feb 6, 2017

Great! Thank you for your contribution. 👍

@fapdash fapdash deleted the 1166-add-asciidoctor-asciidoc-checker branch February 6, 2017 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants