New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `flycheck-tslint-args` #1186

Merged
merged 1 commit into from Jan 5, 2017

Conversation

Projects
None yet
4 participants
@fmdkdd
Member

fmdkdd commented Jan 4, 2017

Closes GH-1184 (which see).

@fmdkdd fmdkdd referenced this pull request Jan 4, 2017

Closed

Further options for tslint #1184

@fmdkdd fmdkdd force-pushed the 1184-add-tslint-args branch from df02847 to 3a91718 Jan 4, 2017

@fmdkdd fmdkdd merged commit e02ec2a into master Jan 5, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@fmdkdd

This comment has been minimized.

Member

fmdkdd commented Jan 5, 2017

Sorry @cpitclaudel, I did not mean to skip your approval. They made the green merge button too tempting.

Are you ok with this going in flycheck? It seemed harmless enough since we already have such options for other checkers. (Next time I'll remember to ask before merging).

@cpitclaudel

This comment has been minimized.

Member

cpitclaudel commented Jan 9, 2017

Are you ok with this going in flycheck? It seemed harmless enough since we already have such options for other checkers.

Yup!

(Next time I'll remember to ask before merging).

Please don't :) I welcome every opportunity to delegate, and I fully trust your judgment on these small issues :) Reverting commits is easy if something goes wrong, and we have plenty of tests.

@fmdkdd

This comment has been minimized.

Member

fmdkdd commented Jan 9, 2017

@cpitclaudel Noted, thanks :)

@fmdkdd fmdkdd deleted the 1184-add-tslint-args branch Jan 9, 2017

@johnny-mh

This comment has been minimized.

johnny-mh commented May 2, 2017

How can i pass this arguments?

I spent many time for passing arguments. is there any example for this?

I set the arguments value like this.

But 'Apply and Save' button is not work. and displaying wrong arguments error.

Cannot save arguments

2017-05-03 1 39 22

Wrong arguments error

2017-05-03 1 40 58

@cpitclaudel

This comment has been minimized.

Member

cpitclaudel commented May 2, 2017

Yes: revert to the default, and use the "Ins" button to insert entries. Currently you're passing a single argument "--project" … "--type-check".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment