New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile checker with hadolint #1194

Merged
merged 1 commit into from Jan 13, 2017

Conversation

Projects
None yet
2 participants
@marsam
Contributor

marsam commented Jan 12, 2017

Hi:

This PR adds Dockerfile checker with hadolint

Tests:

make LANGUAGE=dockerfile integ
cask exec emacs -Q --batch -L .  -l maint/flycheck-compile.el -f flycheck/batch-byte-compile flycheck.el
cask exec emacs -Q --batch -L .  -l maint/flycheck-compile.el -f flycheck/batch-byte-compile flycheck-buttercup.el
cask exec emacs -Q --batch -L .  -l maint/flycheck-compile.el -f flycheck/batch-byte-compile flycheck-ert.el
cask exec emacs -Q --batch -L .  --load test/flycheck-test --load test/run.el -f flycheck-run-tests-main '(and (tag external-tool) (language dockerfile))'
Running tests on Emacs 26.0.50.2, built at 2017-01-11
Running 2 tests (2017-01-12 15:07:08-0500)
   passed  1/2  flycheck-define-checker/dockerfile-hadolint/error
   passed  2/2  flycheck-define-checker/dockerfile-hadolint/warnings

Ran 2 tests, 2 results as expected (2017-01-12 15:07:10-0500)
@cpitclaudel

Looks great! Can you add a note in the Flycheck docs, too?

@marsam

This comment has been minimized.

Contributor

marsam commented Jan 13, 2017

In which archive(s)?

@cpitclaudel

This comment has been minimized.

@marsam

This comment has been minimized.

Contributor

marsam commented Jan 13, 2017

@cpitclaudel

This comment has been minimized.

Member

cpitclaudel commented Jan 13, 2017

Woops, no idea how I missed that :) Thanks!

@cpitclaudel cpitclaudel merged commit d0b058e into flycheck:master Jan 13, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment