Add options to specify XSD schema path for xml checkers #1272
Conversation
|
|
| @@ -1252,12 +1252,20 @@ to view the docstring of the syntax checker. Likewise, you may use | |||
|
|
|||
| Check syntax with `XMLStarlet <http://xmlstar.sourceforge.net>`_. | |||
|
|
|||
| .. defcustom:: flycheck-xml-xmlstarlet-xsd-path | |||
There was a problem hiding this comment.
For the documentation, I would rather merge the two options in one defcustom block, since they are the same for different checkers. Look at how flycheck-clang-args and flycheck-gcc-args are defined in the doc.
flycheck.el
Outdated
| "An XSD schema to validate against." | ||
| :type '(file :tag "XSD schema") | ||
| :safe #'stringp | ||
| :package-version '(flycheck . "32")) |
There was a problem hiding this comment.
We are in 31-snapshot, so that means 31 has not been released yet. (In doubt, you can also check the release tags and see that the latest one is 30).
flycheck.el
Outdated
| "An XSD schema to validate against." | ||
| :type '(file :tag "XSD schema") | ||
| :safe #'stringp | ||
| :package-version '(flycheck . "32")) |
|
Added CHANGES.rst entry in e93b4ad |
|
Great! Thanks for the swift changes. I'm going to need one more thing: could you squash all your commits? We have disabled squashing for preserving GPG signatures (I know, your commits have none, but it's disabled repo-wise). |
|
Squashed into 312b80b |
|
Thanks! |
|
Great! @alexmurray thank you for your contribution. 👍 |
|
No worries - thanks for you guys stepping up to maintain flycheck once @lunaryorn left - it is indispensable. |
Wasn't sure which version number to use for these new options - so picked 32 since current version is 31