Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to specify XSD schema path for xml checkers #1272

Merged
merged 1 commit into from Jun 27, 2017

Conversation

@alexmurray
Copy link
Contributor

commented Jun 26, 2017

Wasn't sure which version number to use for these new options - so picked 32 since current version is 31

@CLAassistant

This comment has been minimized.

Copy link

commented Jun 26, 2017

CLA assistant check
All committers have signed the CLA.

@fmdkdd
Copy link
Member

left a comment

Thank you for your contribution!

The PR looks good; only a couple of minor issues in the documentation.

Could you also add a line to the changelog in CHANGES.rst under 'New features', referencing this PR number? Then we would be good to merge.

@@ -1252,12 +1252,20 @@ to view the docstring of the syntax checker. Likewise, you may use

Check syntax with `XMLStarlet <http://xmlstar.sourceforge.net>`_.

.. defcustom:: flycheck-xml-xmlstarlet-xsd-path

This comment has been minimized.

Copy link
@fmdkdd

fmdkdd Jun 26, 2017

Member

For the documentation, I would rather merge the two options in one defcustom block, since they are the same for different checkers. Look at how flycheck-clang-args and flycheck-gcc-args are defined in the doc.

flycheck.el Outdated
"An XSD schema to validate against."
:type '(file :tag "XSD schema")
:safe #'stringp
:package-version '(flycheck . "32"))

This comment has been minimized.

Copy link
@fmdkdd

fmdkdd Jun 26, 2017

Member

We are in 31-snapshot, so that means 31 has not been released yet. (In doubt, you can also check the release tags and see that the latest one is 30).

flycheck.el Outdated
"An XSD schema to validate against."
:type '(file :tag "XSD schema")
:safe #'stringp
:package-version '(flycheck . "32"))

This comment has been minimized.

Copy link
@fmdkdd

fmdkdd Jun 26, 2017

Member

Same here, version would be 31.

@alexmurray

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2017

Addressed review comments in 0ed8dc7 and 0f0fae1

@alexmurray

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2017

Added CHANGES.rst entry in e93b4ad

@fmdkdd

fmdkdd approved these changes Jun 26, 2017

@fmdkdd

This comment has been minimized.

Copy link
Member

commented Jun 26, 2017

Great! Thanks for the swift changes. I'm going to need one more thing: could you squash all your commits? We have disabled squashing for preserving GPG signatures (I know, your commits have none, but it's disabled repo-wise).

@alexmurray alexmurray force-pushed the alexmurray:master branch from e93b4ad to 312b80b Jun 26, 2017

@alexmurray

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2017

Squashed into 312b80b

@cpitclaudel

This comment has been minimized.

Copy link
Member

commented Jun 27, 2017

Thanks!

@cpitclaudel cpitclaudel merged commit 4d9e16c into flycheck:master Jun 27, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@fmdkdd

This comment has been minimized.

Copy link
Member

commented Jun 27, 2017

Great! @alexmurray thank you for your contribution. 👍

@alexmurray

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2017

No worries - thanks for you guys stepping up to maintain flycheck once @lunaryorn left - it is indispensable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.