Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add emacs-lisp-check-declare checker #1286
referenced this pull request
Jul 19, 2017
The output to ERT is not the most intuitive:
I think the issue here is that your checker is never selected by the Flycheck run by ERT.
You could put your checker as a
Thanks, this looks pretty good. One question: shouldn't this be part of the default ELisp checker?
Actually, it looks like I can't build Emacs 24. I believe I'm running into the bug mentioned here: http://lists.linuxfromscratch.org/pipermail/blfs-support/2016-August/078284.html
It may be a while before I can get Emacs 24. If someone else can fix this, feel free. I suspect it's something like the error filter needing to be tweaked.
Well, that was a waste of time. As it turns out, check-declare does not print the line number on Emacs 24 and stepping through the debugger I learned that Flycheck discards errors that do not have line numbers.
I don't really feel like trying to make this work now, so I've skipped the test on Emacs 24 and documented that check-declare doesn't work on Emacs 24.
Thanks for investigating the issue. So, currently the
If the issue is missing line numbers in the output, you can check for errors that have a
If it's too much a hassle to test that with Emacs 24, let me know. I have an Emacs 24 install I can use to test this workaround.
Great work :) I left two small comments, but I'd also be fine with merging as-is.