Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proselint checker #1304

Merged
merged 2 commits into from Sep 2, 2017

Conversation

@marsam
Copy link
Contributor

commented Aug 20, 2017

Hi:

This is a rebase of #939

Minor changes with respect to #939:

  • Use standard input
  • Added gfm-mode to :modes
  • Replaced json-read-from-string with flycheck-parse-json

Related:

@marsam marsam referenced this pull request Aug 20, 2017

@marsam marsam force-pushed the marsam:checker/proselint branch 2 times, most recently from b518e28 to d27ead2 Aug 20, 2017

marsam added some commits Apr 3, 2016

Unset LC_ALL in proselint checker tests
Unset LC_ALL which is set to LC_ALL=C for other checkers in test/run.el, because
Click, used by ProseLint, when running with python 3 will refuse to work unless
an Unicode locale is exported[1].

[1] http://click.pocoo.org/5/python3/#python-3-surrogate-handling

@marsam marsam force-pushed the marsam:checker/proselint branch from d27ead2 to f13a2fc Aug 20, 2017

@purcell

purcell approved these changes Sep 2, 2017

Copy link
Contributor

left a comment

Looks good to me.

@purcell

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2017

I've looked through this, and it looks like a no-brainer, but would a more active maintainer care to click "merge" if they agree please?

@cpitclaudel cpitclaudel merged commit 9cd155b into flycheck:master Sep 2, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@cpitclaudel

This comment has been minimized.

Copy link
Member

commented Sep 2, 2017

@purcell Thanks for the review. @marsam Thanks for your patience and your excellent work!

@cpitclaudel

This comment has been minimized.

Copy link
Member

commented Sep 2, 2017

Any reason to use (pcase (`"error" …) …) rather than (pcase ("error" …) …) btw? We use the former in multiple places (and it's valid according to the docs), but I hadn't paid attention to it before and I always use the latter.

@fmdkdd

This comment has been minimized.

Copy link
Member

commented Sep 2, 2017

@cpitclaudel I never quite managed to understand the docstring of pcase on that point to figure out if they were really equivalent, so I always go with the backtick, for coherency with the existing code.

@cpitclaudel

This comment has been minimized.

Copy link
Member

commented Sep 2, 2017

They expand to the same thing :) (as an example, here's what our use of pcase in the checkstyle parser expands to:)

(cond ((equal .severity '"error")
       'error)
      ((equal .severity '"warning")
       'warning)
      ((equal .severity '"info")
       'info)
      (t 'error))
@fmdkdd

This comment has been minimized.

Copy link
Member

commented Sep 3, 2017

@cpitclaudel Good to know (but still confusing to have two ways to state the same thing) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.