Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support --suppressions-list in cppcheck #1329

Merged
merged 1 commit into from Oct 22, 2017

Conversation

@unhammer
Copy link
Contributor

commented Sep 21, 2017

Some projects use a file for this, would be handy.

@CLAassistant

This comment has been minimized.

Copy link

commented Sep 21, 2017

CLA assistant check
All committers have signed the CLA.

@@ -6556,6 +6556,7 @@ See URL `http://cppcheck.sourceforge.net/'."
(option-list "-I" flycheck-cppcheck-include-path)
(option-list "--std=" flycheck-cppcheck-standards concat)
(option-list "--suppress=" flycheck-cppcheck-suppressions concat)
(option "--suppressions-list=" flycheck-cppcheck-suppressions-file concat)

This comment has been minimized.

Copy link
@fmdkdd

fmdkdd Oct 19, 2017

Member

Do we have a flycheck-cppcheck-suppressions-file variable? I'm not seeing any. Am I missing something, or do you just setq the variable in your config?

This comment has been minimized.

Copy link
@unhammer

unhammer Oct 19, 2017

Author Contributor

Oh, I had it in dir-locals.el so I didn't notice it missing (there's so much macro-magic in flycheck I often don't know what's auto-defined or not!); added in 5ce2471

@fmdkdd
Copy link
Member

left a comment

Looking good. You'll need to document the variable in doc/languages.rst.

Please add a line to CHANGES.rst as well, under a new heading New features.

flycheck.el Outdated
:type '(choice (const :tag "Default" nil)
(file :tag "Suppressions file"))
:safe #'stringp
:package-version '(flycheck . "31"))

This comment has been minimized.

Copy link
@fmdkdd

fmdkdd Oct 20, 2017

Member

31 is already out, so that variable would go into version 32.

@unhammer

This comment has been minimized.

Copy link
Contributor Author

commented Oct 22, 2017

Should this be rebased/squashed, or is it OK like this?

@cpitclaudel

This comment has been minimized.

Copy link
Member

commented Oct 22, 2017

I like clean commits; a rebase would be nice :)

support --suppressions-list file in cppcheck
new defcustom flycheck-cppcheck-suppressions-file + documentation,
changelog entry

@unhammer unhammer force-pushed the unhammer:cppcheck-suppressions-list branch from a68a3ba to 9f8735f Oct 22, 2017

@unhammer

This comment has been minimized.

Copy link
Contributor Author

commented Oct 22, 2017

rebased

@fmdkdd

fmdkdd approved these changes Oct 22, 2017

@fmdkdd fmdkdd merged commit 66b0e49 into flycheck:master Oct 22, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@fmdkdd

This comment has been minimized.

Copy link
Member

commented Oct 22, 2017

Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.