Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jsonnet checker #1345

Merged
merged 2 commits into from Oct 9, 2017

Conversation

@mgyucht
Copy link
Contributor

commented Oct 8, 2017

This PR adds a checker to flycheck supporting the Jsonnet templating language. See https://jsonnet.org for details about the language.

@CLAassistant

This comment has been minimized.

Copy link

commented Oct 8, 2017

CLA assistant check
All committers have signed the CLA.

@fmdkdd

fmdkdd approved these changes Oct 8, 2017

Copy link
Member

left a comment

Looks great! Thank you for the contribution 👍

Could you add a line to CHANGES.rst as well?

@mgyucht

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2017

Done!

@mgyucht

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2017

Not exactly sure what failed here... @fmdkdd could you provide any insight?

@mgyucht

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2017

@fmdkdd Apparently the init method of HTMLXrefDB was missing a doccomment, so I added one...? The tests seem to pass now.

@fmdkdd

This comment has been minimized.

Copy link
Member

commented Oct 9, 2017

Strange... why did flake8 not complain the first time? The pip packages should have been cached, so I don't think flake8 could have been updated between your two commits...

Anyway, LGTM. Could you squash your commits before I can merge? One commit for the __init__ docstring, and one commit for the rest would be best.

mgyucht added some commits Oct 8, 2017

Add jsonnet flychecker
Add test

Update CHANGES.rst

Fix update
Add __init__ documentation comment
Shorter doccomment

@mgyucht mgyucht force-pushed the mgyucht:jsonnet branch from c9b1403 to 58f63da Oct 9, 2017

@mgyucht

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2017

Commits squashed! Thanks for your help with this!

@fmdkdd fmdkdd merged commit cfe02c0 into flycheck:master Oct 9, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@fmdkdd

This comment has been minimized.

Copy link
Member

commented Oct 9, 2017

Great! Thank you for a fine patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.